Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added missing $is_beta class property to FS_User #676

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bfintal
Copy link
Contributor

@bfintal bfintal commented Dec 12, 2023

Fixes #675

@swashata swashata changed the base branch from master to develop January 31, 2024 08:07
@swashata swashata changed the base branch from develop to master January 31, 2024 08:15
@swashata
Copy link
Contributor

Hey @bfintal thank you for the PR. As I can see it is adding a property to the FS_User class. But we have moved the is_beta from user to site/install quite some time back.

So could it be that the error you're getting is due to some old/legacy account data? We have also incorporated a garbage collector, so that old data might have gotten deleted already.

Could you please confirm if this fix is still needed, even after running the garbage collector?

@andreiglingeanu
Copy link

@swashata I can confirm that removing the cached serialized objects from the DB helped fix this issue in my end.
So yes, indeed adding this flag in the class is not needed from my point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

White space on top of admin because of unseen PHP error
3 participants